VPMS Web Application

New style of selection dialog for workspaces eg. Customer, Product etc

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.5
  • Fix Version/s: 1.5
  • Component/s: None
  • Labels:
    None

Description

The idea is to allow the user to create a list then work from that list to edit the indivual items. This is contrary to the current situation where selection of a customer, patient, product etc is done through the SELECT button. This means that the list dissapears after a selection is made and needs to be re created to make another selection.
Forum: http://www.openvpms.org/forum/new-style-multi-selection-box-editing-lookups-types-organisation-templates-users-customers-pat

A sample workspace would work like this:
1. Filter your list by entering Name etc
2. Make a selection and edit.
3. An editor pops up.
4. When you complete your edits and close the editor the list is still there so another secltion can be made.

This would be very helpful in product editing but even customer selection can be very handy as well.

The current areas suggested for this development have included; Customer, Patient, Product, Template workspaces but I can't think of an area that this would not work in.

Open for questions from the developers.

Activity

Hide
Matt Costa added a comment -

Tim suggested in forums:
"...For simple edits, would being able to edit directly in the table be simpler?

This would include things like changing strings, dates, checkboxes and single participations (e.g, patient, customer, etc)

You could still have the option of popping up an edit dialog for editing more complex nodes..."

I think this would be a great option. How much more information do you guys need to start thinking about a costing?

Show
Matt Costa added a comment - Tim suggested in forums: "...For simple edits, would being able to edit directly in the table be simpler? This would include things like changing strings, dates, checkboxes and single participations (e.g, patient, customer, etc) You could still have the option of popping up an edit dialog for editing more complex nodes..." I think this would be a great option. How much more information do you guys need to start thinking about a costing?
Hide
Tim Anderson added a comment -

For the case where you just want to edit from a query list, much of the code is already in place.
I would estimate 2 hours + 1 hour for each workspace.

For the table editing approach, there is currently no support for this, and some archetypes lend themselves better to table editing than others.
(e.g archetypes with few or no relationships). To add support for table editing starts at 12 hours + 2 hours for each new workspace.

From a L&F perspective, do you want:

  • a new workspace for for , e.g Customers -> Batch Edit, Patient -> Batch Edit
    Contains a query and browser which functions the same as the selection dialog but pops up an edit dialog when you select a row
  • a new editable selection dialog, launched via a new button in the existing workspaces
Show
Tim Anderson added a comment - For the case where you just want to edit from a query list, much of the code is already in place. I would estimate 2 hours + 1 hour for each workspace. For the table editing approach, there is currently no support for this, and some archetypes lend themselves better to table editing than others. (e.g archetypes with few or no relationships). To add support for table editing starts at 12 hours + 2 hours for each new workspace. From a L&F perspective, do you want:
  • a new workspace for for , e.g Customers -> Batch Edit, Patient -> Batch Edit Contains a query and browser which functions the same as the selection dialog but pops up an edit dialog when you select a row
  • a new editable selection dialog, launched via a new button in the existing workspaces
Hide
Matt Costa added a comment -

Hi Tim,
I think a new editable selection dialog, launched via a new button in the existing workspaces would work best given the use cases raised from the users forum.

I think to start with the
Customer, Patient, Product, Template selection dialogs would be all that is required (any more Tony?).

Also can we have the selection dialog behaviour such that the previous search results are retained when brought back up. This allows sequential editing if desired.
The cursor focus ideally would be in the search string box (name) with previous text highlighted so a new search can be fired quickly and easily.

Cheers,
matt C

Show
Matt Costa added a comment - Hi Tim, I think a new editable selection dialog, launched via a new button in the existing workspaces would work best given the use cases raised from the users forum. I think to start with the Customer, Patient, Product, Template selection dialogs would be all that is required (any more Tony?). Also can we have the selection dialog behaviour such that the previous search results are retained when brought back up. This allows sequential editing if desired. The cursor focus ideally would be in the search string box (name) with previous text highlighted so a new search can be fired quickly and easily. Cheers, matt C
Hide
Tony De Keizer added a comment -

Hi Guys.
I would say the most important workspaces for this style of editing would be

Products
Organisation
Types
Lookups
Templates
Users

Not sure the use for Customers, Patients ?

The edit from a query list with appropriate filters is sufficient I believe.

Show
Tony De Keizer added a comment - Hi Guys. I would say the most important workspaces for this style of editing would be Products Organisation Types Lookups Templates Users Not sure the use for Customers, Patients ? The edit from a query list with appropriate filters is sufficient I believe.
Hide
Matt Costa added a comment -

Hi Tony,
I had forgotten some of the setup workspaces.

I think the advantage for customers (less so for patients) is when needing to jump into a series of customers. An example would be the search for a partial microchip or other identity. Currently the search needs to be re executed after entering each customer or patient.

The patient select dialog would get less use especially now that customer searching includes patient results. The circumstance it might be used is when searching using the All Patients option. The subsequent list may need to have different selections made multiple times.

Matt

Show
Matt Costa added a comment - Hi Tony, I had forgotten some of the setup workspaces. I think the advantage for customers (less so for patients) is when needing to jump into a series of customers. An example would be the search for a partial microchip or other identity. Currently the search needs to be re executed after entering each customer or patient. The patient select dialog would get less use especially now that customer searching includes patient results. The circumstance it might be used is when searching using the All Patients option. The subsequent list may need to have different selections made multiple times. Matt
Hide
Matthew Young added a comment -

Hi Guys,

Patients and Clients would definately be useful. Sometimes when recalling a case you can only recall certain details such as a surname or patient name. There may be multiple patients with the same surname and you need to enter into the record to check if it's the right one. Then if not go back to the list and check the next, etc, etc. So it definitely has it's purpose.

Another proposed workspace for this: archetypes.

Show
Matthew Young added a comment - Hi Guys, Patients and Clients would definately be useful. Sometimes when recalling a case you can only recall certain details such as a surname or patient name. There may be multiple patients with the same surname and you need to enter into the record to check if it's the right one. Then if not go back to the list and check the next, etc, etc. So it definitely has it's purpose. Another proposed workspace for this: archetypes.
Hide
Tony De Keizer added a comment -

Can I suggest we work on changing the workspaces mentioned above (including archetypes) and then raise a new JIRA for new workspaces to deal with batch editing of customers and patients ?

Show
Tony De Keizer added a comment - Can I suggest we work on changing the workspaces mentioned above (including archetypes) and then raise a new JIRA for new workspaces to deal with batch editing of customers and patients ?
Hide
Matt Costa added a comment -

So to be clear, current list for new selection dialogs are;
Products
Organisation
Types
Lookups
Templates
Users
Customers
Patients
Archetypes

And a new Jira for batch editing of Customers and Patients?

Show
Matt Costa added a comment - So to be clear, current list for new selection dialogs are; Products Organisation Types Lookups Templates Users Customers Patients Archetypes And a new Jira for batch editing of Customers and Patients?
Hide
Tony De Keizer added a comment -

Hi Matt,

This JIRA will be modified to relate purely to the workspaces mentioned above using the simple query list approach (option1) mentioned by Tim. We need to supply relevant query filter options for each workspace. i.e.

Product: Archetype, Product Type, Name
Organisation: Archetype, Name
Type: Archetype , Name
Lookups: Archetype, Name
Templates: template type, name
Users: name
Archetypes: name

A new JIRA will be added for batch customer editing as well as batch patient editing (separate).

Show
Tony De Keizer added a comment - Hi Matt, This JIRA will be modified to relate purely to the workspaces mentioned above using the simple query list approach (option1) mentioned by Tim. We need to supply relevant query filter options for each workspace. i.e. Product: Archetype, Product Type, Name Organisation: Archetype, Name Type: Archetype , Name Lookups: Archetype, Name Templates: template type, name Users: name Archetypes: name A new JIRA will be added for batch customer editing as well as batch patient editing (separate).
Hide
Matt Costa added a comment -

Hi guys,
I have a user ready to fund this fully and get it underway but they have a request for a modification and given it is an addition rather then changing any of the existing spec, I thought I would ask here and get you to provide a revised time estimate Tim.

The request is to add a "Next" and "Previous" button to the editor that can move directly to the next or previous item in the query list. Is this possible?

Matt C

Show
Matt Costa added a comment - Hi guys, I have a user ready to fund this fully and get it underway but they have a request for a modification and given it is an addition rather then changing any of the existing spec, I thought I would ask here and get you to provide a revised time estimate Tim. The request is to add a "Next" and "Previous" button to the editor that can move directly to the next or previous item in the query list. Is this possible? Matt C
Hide
Tim Anderson added a comment -

OK, there's a few requirements in here now.
1. a new editable selection dialog, launched via a new button in the existing workspaces

Button will be added to the following workspaces:

  • Products
  • Organisation
  • Types
  • Lookups
  • Templates
  • Users
  • Customers
  • Patients
  • Archetypes
    Estimated time = 2 hours + 1 per workspace = 11 hours

2. "Next" and "Previous" button to the editor that can move directly to the next or previous item in the query list
Do you want it to go to the next page if there is one when you get to the end of a page, or cycle back to the top?
Esimtated time = 2 hours

3. Also can we have the selection dialog behaviour such that the previous search results are retained when brought back up. This allows sequential editing if desired.
The cursor focus ideally would be in the search string box (name) with previous text highlighted so a new search can be fired quickly and easily.

  • Text highlighting is not supported by the echo web framework. Could add it, but requires creating a new text field. Need more investigation to determine timeframe
  • Save query state : Estimated time = 1 hour per workspace = 9 hours
Show
Tim Anderson added a comment - OK, there's a few requirements in here now. 1. a new editable selection dialog, launched via a new button in the existing workspaces Button will be added to the following workspaces:
  • Products
  • Organisation
  • Types
  • Lookups
  • Templates
  • Users
  • Customers
  • Patients
  • Archetypes Estimated time = 2 hours + 1 per workspace = 11 hours
2. "Next" and "Previous" button to the editor that can move directly to the next or previous item in the query list Do you want it to go to the next page if there is one when you get to the end of a page, or cycle back to the top? Esimtated time = 2 hours 3. Also can we have the selection dialog behaviour such that the previous search results are retained when brought back up. This allows sequential editing if desired. The cursor focus ideally would be in the search string box (name) with previous text highlighted so a new search can be fired quickly and easily.
  • Text highlighting is not supported by the echo web framework. Could add it, but requires creating a new text field. Need more investigation to determine timeframe
  • Save query state : Estimated time = 1 hour per workspace = 9 hours
Hide
Matt Costa added a comment -

Thanks for this summary Tim.
I will update the development costing on the OpenVPMS website after tonights meeting.

Wrt point 3. The "Save Query State", I think what was meant by that was that the query list was still there after the user finished editing a selection and returned to the list. Is that what you mean by save query state?

Matt C

Show
Matt Costa added a comment - Thanks for this summary Tim. I will update the development costing on the OpenVPMS website after tonights meeting. Wrt point 3. The "Save Query State", I think what was meant by that was that the query list was still there after the user finished editing a selection and returned to the list. Is that what you mean by save query state? Matt C
Hide
Tim Anderson added a comment -

Misunderstanding on my part. I took it to mean that the previous query would be re-run if you open the editable selection dialog from the workspace.
If you are just talking about being presented with the same list of results in the selection dialog after you have edited an item, then that will be the default behaviour.

Show
Tim Anderson added a comment - Misunderstanding on my part. I took it to mean that the previous query would be re-run if you open the editable selection dialog from the workspace. If you are just talking about being presented with the same list of results in the selection dialog after you have edited an item, then that will be the default behaviour.
Hide
Matt Costa added a comment -

Great. That's what I thought!
Thanks.

Show
Matt Costa added a comment - Great. That's what I thought! Thanks.
Hide
Matt Costa added a comment -

Hi Tim,
This project can go ahead for points 1 & 2 as per follows:
1. a new editable selection dialog, launched via a new button in the existing workspaces

Button will be added to the following workspaces:

  • Products
  • Organisation
  • Types
  • Lookups
  • Templates
  • Users
  • Customers
  • Patients
  • Archetypes
    Estimated time = 2 hours + 1 per workspace = 11 hours

2. "Next" and "Previous" button to the editor that can move directly to the next or previous item in the query list
Do you want it to go to the next page if there is one when you get to the end of a page, or cycle back to the top?
Estimated time = 2 hours

We have funding.

Thanks

Show
Matt Costa added a comment - Hi Tim, This project can go ahead for points 1 & 2 as per follows: 1. a new editable selection dialog, launched via a new button in the existing workspaces Button will be added to the following workspaces:
  • Products
  • Organisation
  • Types
  • Lookups
  • Templates
  • Users
  • Customers
  • Patients
  • Archetypes Estimated time = 2 hours + 1 per workspace = 11 hours
2. "Next" and "Previous" button to the editor that can move directly to the next or previous item in the query list Do you want it to go to the next page if there is one when you get to the end of a page, or cycle back to the top? Estimated time = 2 hours We have funding. Thanks
Hide
Tim Anderson added a comment - - edited

Changes applied, but with different a implementation to that originally described.
The requirement:

1. a new editable selection dialog, launched via a new button in the existing workspaces

didn't work too well from a useability perspective.

It has been replaced with a query and browser within the workspace itself.
This allows:

  • queries to be performed within the workspace without popping up a selection dialog
  • the results of the query to be browsed, viewed and edited

Editing an row is done by clicking on it and selecting Edit.
This pops up a standard edit dialog, which also includes Previous and Next buttons to edit the previous and next row respectively.

The following workspaces have been updated to use this layout:

  • Products -> Information
  • Administration -> Organisation
  • Administration -> Types
  • Administration -> Templates
  • Administration -> Users
  • Administration -> Roles
  • Administration -> Lookups
  • Administration -> Authorities
  • Administration -> Archetypes

The following workspaces have NOT been updated:

  • Customers -> Information
  • Patients -> Information
  • Suppliers -> Information (not mentioned in the inital JIRA)

They are not amenable to the query/browser style of workspace.

Changes applied to vpms, revisions: 3790, 3794, 3798, 3803

Show
Tim Anderson added a comment - - edited Changes applied, but with different a implementation to that originally described. The requirement:
1. a new editable selection dialog, launched via a new button in the existing workspaces
didn't work too well from a useability perspective. It has been replaced with a query and browser within the workspace itself. This allows:
  • queries to be performed within the workspace without popping up a selection dialog
  • the results of the query to be browsed, viewed and edited
Editing an row is done by clicking on it and selecting Edit. This pops up a standard edit dialog, which also includes Previous and Next buttons to edit the previous and next row respectively. The following workspaces have been updated to use this layout:
  • Products -> Information
  • Administration -> Organisation
  • Administration -> Types
  • Administration -> Templates
  • Administration -> Users
  • Administration -> Roles
  • Administration -> Lookups
  • Administration -> Authorities
  • Administration -> Archetypes
The following workspaces have NOT been updated:
  • Customers -> Information
  • Patients -> Information
  • Suppliers -> Information (not mentioned in the inital JIRA)
They are not amenable to the query/browser style of workspace. Changes applied to vpms, revisions: 3790, 3794, 3798, 3803
Hide
Tony De Keizer added a comment -

Default double click behaviour should be edit not view mode.

Show
Tony De Keizer added a comment - Default double click behaviour should be edit not view mode.
Hide
Tim Anderson added a comment -

Changes applied to vpms, revision 3949

Show
Tim Anderson added a comment - Changes applied to vpms, revision 3949
Hide
Tony De Keizer added a comment -

Tested VPMS. OK.

Show
Tony De Keizer added a comment - Tested VPMS. OK.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
Not Specified
Original Estimate - Not Specified
Remaining:
0h
Remaining Estimate - 0h
Logged:
13h
Time Spent - 13h